zhangyu981027 commented on code in PR #21545:
URL: https://github.com/apache/nuttx/pull/21545#discussion_r4614720706


##########
arch/tricore/src/CMakeLists.txt:
##########
@@ -22,12 +22,14 @@
 
 add_subdirectory(${NUTTX_CHIP_ABS_DIR} exclude_chip EXCLUDE_FROM_ALL)
 add_subdirectory(common)
+add_subdirectory(aurix)
 
 # Include directories (before system ones) as PUBLIC so that it can be exposed
 # to libboard
-target_include_directories(arch BEFORE PUBLIC ${NUTTX_CHIP_ABS_DIR} common)
+target_include_directories(arch BEFORE PUBLIC ${NUTTX_CHIP_ABS_DIR} common
+                                              aurix)
 
 if(NOT CONFIG_BUILD_FLAT)
   target_include_directories(arch_interface BEFORE PUBLIC ${NUTTX_CHIP_ABS_DIR}
-                                                          common)
+                                                          common aurix)

Review Comment:
   I read that CONFIG_ARCH_CHIP_CUSTOM support for an external or out-of-tree 
System-on-a-Chip (SoC).
   
   aurix holds the peripheral IP drivers shared by TC3x and TC4x, so it stays 
next to common, but I take the point that the generic arch build should only 
know chip and common: tc3xx and tc4xx. I will change pull in aurix from their 
Make.defs and CMakeLists.txt, as imx6 pulls in armv7-a.
   
   
   seems no change, if CONFIG_ARCH_CHIP_CUSTOM, should use no arch/tricore chip 
driver's code



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to