jingfei195887 opened a new pull request, #22046:
URL: https://github.com/apache/nuttx/pull/22046

   ## Summary
   
   Fix the master build break in `fs/vfs/fs_sync.c`:
   
   ```
   vfs/fs_sync.c:124:3: error: too few arguments to function 'foreach_inode'
   ```
   
   #21999 (72ba9b9d95f) moved `sync()` into `fs/vfs/fs_sync.c` and added a 
`foreach_inode()` call there, while #22013 (6be5713b494) added a `readonly` 
argument to `foreach_inode()`. Each PR built on its own; together they do not.
   
   Pass `readonly=true`: the syncfs walk only visits mountpoint inodes, so it 
keeps the inode read lock it took before the signature change.
   
   ## Impact
   
   Build fix only, no behavior change. Every configuration with mountpoints 
enabled currently fails to build on master.
   
   ## Testing
   
   Host: Linux x86_64, gcc 13.1.0, base 7b4e4375757 (upstream master).
   
   - master: `sim:nsh` fails with the error above.
   - this PR: `sim:nsh` (+ `CONFIG_FS_HOSTFS`, `CONFIG_FS_TMPFS`) builds with 
make and CMake, no warnings in the changed file; `ostest` exits with status 0.
   - `tools/checkpatch.sh` passes.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to