This is an automated email from the ASF dual-hosted git repository.

GUIDINGLI pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/nuttx.git

commit 1d928f4619e942e1b5f305cb5767ddb51949eb85
Author: wangzitong7 <[email protected]>
AuthorDate: Thu Mar 5 21:10:17 2026 +0800

    net/arp: add debug logging for error and skip paths.
    
    Add nwarn() and ninfo() messages to the error handling and skip paths
    in arp_acd, arp_format, arp_out and arp_table to make failures easier
    to diagnose.
    
    Signed-off-by: wangzitong7 <[email protected]>
---
 net/arp/arp_acd.c    | 2 ++
 net/arp/arp_format.c | 1 +
 net/arp/arp_out.c    | 1 +
 net/arp/arp_table.c  | 7 +++++++
 4 files changed, 11 insertions(+)

diff --git a/net/arp/arp_acd.c b/net/arp/arp_acd.c
index 6657d3f0f21..db75344992b 100644
--- a/net/arp/arp_acd.c
+++ b/net/arp/arp_acd.c
@@ -82,6 +82,7 @@ static void arp_acd_arrange_announce(FAR struct net_driver_s 
*dev)
 
   int ret = work_queue(LPWORK, &dev->d_acd.work, arp_acd_try_announce,
                        (FAR void *)dev, DSEC2TICK(dev->d_acd.ttw));
+
   if (ret != OK)
     {
       nerr("ERROR ret %d \n", ret);
@@ -135,6 +136,7 @@ static void arp_acd_try_announce(FAR void *net_dev)
 
   if (dev == NULL || dev->d_acd.state != ARP_ACD_STATE_ANNOUNCING)
     {
+      nwarn("WARNING: ACD announce skipped, dev=%p\n", dev);
       return;
     }
 
diff --git a/net/arp/arp_format.c b/net/arp/arp_format.c
index 8b0949cd502..3fd32e5cb2b 100644
--- a/net/arp/arp_format.c
+++ b/net/arp/arp_format.c
@@ -84,6 +84,7 @@ void arp_format(FAR struct net_driver_s *dev, in_addr_t 
ipaddr)
 
   if (netdev_iob_prepare(dev, false, 0) != OK)
     {
+      nwarn("WARNING: Failed to prepare IOB for ARP packet\n");
       return;
     }
 
diff --git a/net/arp/arp_out.c b/net/arp/arp_out.c
index f6e8fb99cd9..2707d96754e 100644
--- a/net/arp/arp_out.c
+++ b/net/arp/arp_out.c
@@ -227,6 +227,7 @@ void arp_out(FAR struct net_driver_s *dev)
 
       if (ipaddr == INADDR_ANY)
         {
+          nwarn("WARNING: No valid router address for destination\n");
           dev->d_len = 0;
           return;
         }
diff --git a/net/arp/arp_table.c b/net/arp/arp_table.c
index eec837bca5a..d5d7d1c593d 100644
--- a/net/arp/arp_table.c
+++ b/net/arp/arp_table.c
@@ -273,6 +273,7 @@ static void arp_get_arpreq(FAR struct arpreq *output,
 static void arp_unreach_work(FAR void *param)
 {
   FAR struct arp_entry_s *tabptr = (FAR struct arp_entry_s *)param;
+
   iob_free_queue(&tabptr->at_queue);
 }
 #endif
@@ -349,6 +350,7 @@ int arp_update(FAR struct net_driver_s *dev, in_addr_t 
ipaddr,
 
   if ((tabptr->at_flags & ATF_PERM) != 0 && (flags & ATF_PERM) == 0)
     {
+      nwarn("WARNING: Cannot overwrite permanent ARP entry\n");
       return -ENOSPC;
     }
 
@@ -502,6 +504,7 @@ int arp_find(in_addr_t ipaddr, FAR uint8_t *ethaddr,
                  sizeof(tabptr->at_ethaddr)) == 0)
         {
           clock_t elapsed;
+
           elapsed = clock_systime_ticks() - tabptr->at_time;
           if (elapsed <= ARP_INPROGRESS_TICK)
             {
@@ -588,9 +591,12 @@ int arp_delete(in_addr_t ipaddr, FAR struct net_driver_s 
*dev)
       /* Yes.. Set the IP address to zero to "delete" it */
 
       tabptr->at_ipaddr = 0;
+      ninfo("ARP entry deleted for IP %08lx\n", (unsigned long)ipaddr);
       return OK;
     }
 
+  nwarn("WARNING: ARP entry not found for deletion, IP %08lx\n",
+        (unsigned long)ipaddr);
   return -ENOENT;
 }
 
@@ -736,6 +742,7 @@ int arp_queue_iob(FAR struct net_driver_s *dev, in_addr_t 
ipaddr,
       return -ENOMEM;
     }
 
+  nwarn("WARNING: No in-progress ARP entry found for IOB queue\n");
   return -ENOENT;
 }
 #endif

Reply via email to