This is an automated email from the ASF dual-hosted git repository. GUIDINGLI pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/nuttx.git
commit 24c15c455bc4dc50c27d4bb7d6b7af50fce2633e Author: wangshaoxin <[email protected]> AuthorDate: Wed Aug 27 13:11:41 2025 +0800 drivers/serial/uart_rpmsg: keep a copy of the device and cpu names uart_rpmsg_init() stored the caller's devname and cpuname pointers, so a caller passing a temporary buffer left them dangling. Copy both into the private data. Signed-off-by: wangshaoxin <[email protected]> Signed-off-by: Bowen Wang <[email protected]> --- drivers/serial/uart_rpmsg.c | 9 +++++---- 1 file changed, 5 insertions(+), 4 deletions(-) diff --git a/drivers/serial/uart_rpmsg.c b/drivers/serial/uart_rpmsg.c index 17fd7d143dd..760d9b22e99 100644 --- a/drivers/serial/uart_rpmsg.c +++ b/drivers/serial/uart_rpmsg.c @@ -45,6 +45,7 @@ #define UART_RPMSG_DEV_CONSOLE "/dev/console" #define UART_RPMSG_DEV_PREFIX "/dev/tty" #define UART_RPMSG_EPT_PREFIX "rpmsg-tty" +#define UART_RPMSG_NAME_SIZE (RPMSG_NAME_SIZE - 10) #define UART_RPMSG_TTY_WRITE 0 #define UART_RPMSG_TTY_WAKEUP 1 @@ -78,8 +79,8 @@ struct uart_rpmsg_priv_s { struct rpmsg_endpoint ept; mutex_t lock; - FAR const char *devname; - FAR const char *cpuname; + char devname[UART_RPMSG_NAME_SIZE]; + char cpuname[UART_RPMSG_NAME_SIZE]; FAR void *recv_data; bool last_upper; }; @@ -446,8 +447,8 @@ int uart_rpmsg_init(FAR const char *cpuname, FAR const char *devname, sizeof(struct uart_rpmsg_priv_s); dev->xmit.buffer = dev->recv.buffer + buf_size; priv = dev->priv; - priv->cpuname = cpuname; - priv->devname = devname; + strlcpy(priv->cpuname, cpuname, sizeof(priv->cpuname)); + strlcpy(priv->devname, devname, sizeof(priv->devname)); nxmutex_init(&priv->lock);
