ssekar15 commented on code in PR #21977:
URL: https://github.com/apache/nuttx/pull/21977#discussion_r4638913422


##########
arch/tricore/src/tc4xx/tc4xx_timerisr.c:
##########
@@ -49,8 +48,10 @@
 void up_timer_initialize(void)
 {
   struct oneshot_lowerhalf_s *lower;
+  int cpu = up_cpu_index();

Review Comment:
   Per-core timer doesn't happen: "Use the STM of the current core" has no 
effect, because up_cpu_index is always 0 on TriCore. Assume I have two NuttX 
image build for core 0 and core 1, up_cpu_index always 0.
   
   As per @xiaoxiang781216 statement,  existing functionality should not to 
break, current Nuttx upstream has only AMP and until the adaption lands use 
tricore_core_id
   
   please allow the reviewer decides to mark the resolved.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to