santhosh-c-c commented on code in PR #22047:
URL: https://github.com/apache/nuttx/pull/22047#discussion_r4641371702


##########
sched/sched/sched_setaffinity.c:
##########
@@ -82,7 +82,13 @@ int nxsched_set_affinity(pid_t pid, size_t cpusetsize,
 
   /* Make sure that affinity mask is valid */
 
-  if (*mask == 0)
+#ifdef CONFIG_BMP

Review Comment:
   Thanks, that page says the same: `BMP is an enhanced and restricted form of 
SMP that statically binds an application's tasks to specific cores`, with one 
kernel running across all cores (SMP). That is what this PR does.
   
   `On cache coherence`: right, the TriCore data cache is not coherent, so with 
SMP the data cache is bypassed on all CPUs (DCON0.DCBYP, set in the boot code 
of every CPU). Kernel data is in the DLMU (uncached through the bypass) and 
stacks/heap in the DSPR (never cached), only the program cache stays on, which 
is safe for read-only flash code.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to