ssekar15 commented on code in PR #22126:
URL: https://github.com/apache/nuttx/pull/22126#discussion_r4644938193
##########
arch/tricore/src/common/tricore_fork.c:
##########
@@ -243,6 +243,10 @@ pid_t up_fork(bool vfork)
struct fork_s context;
uintptr_t *csa_addr;
+ /* Preserve the return value across the lower context restore. */
+
+ volatile pid_t ret;
Review Comment:
just declare what rslcx overwrites instead of the volatile local?
ret = tricore_fork(vfork, &context);
/* rslcx reloads D0-D7 and A2-A7 from the CSA of svlcx */
__asm__ __volatile__ ("rslcx" ::: "d0", "d1", "d2", "d3", "d4", "d5",
"d6", "d7", "a2", "a3", "a4", "a5", "a6", "a7",
"memory");
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]