casaroli commented on code in PR #21359:
URL: https://github.com/apache/nuttx/pull/21359#discussion_r4646153620
##########
cmake/nuttx_multiple_link.cmake:
##########
@@ -35,6 +35,8 @@ if(CONFIG_ALLSYMS)
set(ALLSYMS_INCDIR ${NUTTX_DIR}/include ${NUTTX_BINARY_DIR}/include)
set_source_files_properties(${ALLSYMS_SOURCE} PROPERTIES INCLUDE_DIRECTORIES
"${ALLSYMS_INCDIR}")
+ set_source_files_properties(
+ ${ALLSYMS_SOURCE} PROPERTIES COMPILE_OPTIONS -fno-sanitize=kernel-address)
Review Comment:
Still open on 74c57d638ff, and the commit message now says the CMake
multi-link path is covered. `define_multiple_link_target()` compiles
allsyms_${linktimes}.c and kasan_global_${linktimes}.c, the files in the final
image, without -fno-sanitize=kernel-address: only the first-pass
allsyms_empty.c and kasan_global.c get it.
Fix: set the same COMPILE_OPTIONS on `${LINK_ALLSYMS_SOURCE}` and
`${LINK_KASAN_GLOBAL_SOURCE}`, or drop the CMake claim from the commit message.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]