This is an automated email from the ASF dual-hosted git repository. xiaoxiang781216 pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/nuttx.git
commit a252390f19484abe3934cde0400ade887f3622f3 Author: Bowen Wang <[email protected]> AuthorDate: Wed May 20 17:03:47 2026 +0800 drivers/syslog/syslog_rpmsg: recheck the space after a transfer syslog_rpmsg_addbuf() decided whether to overwrite old log from the return value of syslog_rpmsg_transfer(), which only says that a transfer was started, not that it freed enough space. Recheck the free space instead. Signed-off-by: Bowen Wang <[email protected]> --- drivers/syslog/syslog_rpmsg.c | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/drivers/syslog/syslog_rpmsg.c b/drivers/syslog/syslog_rpmsg.c index c50161e8778..62cf1ad3e6d 100644 --- a/drivers/syslog/syslog_rpmsg.c +++ b/drivers/syslog/syslog_rpmsg.c @@ -241,8 +241,6 @@ static void syslog_rpmsg_addbuf(FAR struct syslog_rpmsg_s *priv, if (SYSLOG_RPMSG_SPACE(header) < len) { - bool ret = false; - if (!up_interrupt_context() && !sched_idletask()) { /* Unlock before entering syslog_rpmsg_transfer, @@ -250,11 +248,11 @@ static void syslog_rpmsg_addbuf(FAR struct syslog_rpmsg_s *priv, */ spin_unlock_irqrestore(&priv->lock, flags); - ret = syslog_rpmsg_transfer(priv, true); + syslog_rpmsg_transfer(priv, true); flags = spin_lock_irqsave(&priv->lock); } - if (!ret) + if (SYSLOG_RPMSG_SPACE(header) < len) { overwritten = true; }
