ssekar15 commented on code in PR #21805:
URL: https://github.com/apache/nuttx/pull/21805#discussion_r4652439219


##########
arch/tricore/src/cmake/chip.cmake:
##########
@@ -22,15 +22,15 @@
 
 set(PLATFORM_FLAGS)
 
-if(CONFIG_ARCH_CHIP_TC3XX)
+if(CONFIG_ARCH_CHIP_FAMILY_TC3X)
   if(CONFIG_TRICORE_TOOLCHAIN_TASKING)
     add_compile_options(--default-near-size=0)
     add_compile_options(--cpu=tc39xb)
     add_link_options(-Ctc39xb)
   else()
     list(APPEND PLATFORM_FLAGS -mcpu=tc39xx -mtc162)
   endif()
-elseif(CONFIG_ARCH_CHIP_TC4XX)
+elseif(CONFIG_ARCH_CHIP_FAMILY_TC4X)

Review Comment:
   Ack, weird no distinguish family/part both follows ARCH_CHIP_ directly
   
   Family: arm's chip choice names the family ARCH_CHIP_<FAMILY>, for example 
ARCH_CHIP_STM32F4
   Part: a part inside a family is ARCH_CHIP_<PART>, for example 
ARCH_CHIP_STM32F407VG



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to