vrmay23 commented on PR #22139:
URL: https://github.com/apache/nuttx/pull/22139#issuecomment-7066942631

   Hello!
   
   @raiden00pl I did the port of interrupt_flow and switch_on_return to 
plantuml and they look good indeed.
   
   I also tried with common_and_arch, but this one is not a sequence, it is a 
block diagram, and the result was really worse than the SVG (see below, first 
is plantuml and second is SVG). So I kept this one as SVG.
   
   [image 1 - svg]
   <img width="1377" height="382" alt="image" 
src="https://github.com/user-attachments/assets/e14af40e-42ad-4533-a541-c2ad2d24973a";
 />
   
   
   [image 2 - plantuml]
   <img width="900" height="165" alt="image" 
src="https://github.com/user-attachments/assets/00b94292-997a-4815-a6bf-7195dc1183c9";
 />
   
   <img width="1318" height="494" alt="image" 
src="https://github.com/user-attachments/assets/bdcbaff4-1e60-4bb6-9d28-89ab218408c8";
 />
   
   
   By the way, I agree: UML flows really makes sense for sequence diagrams, but 
we will not necessarily get good results in every case where a sequence does 
not apply, as is the case of common_and_arch. I believe it is wise to change 
the diagrams to UML and use plantuml (I can even redo the ones already in 
mainline), but only for the ones where it makes sense.
   
   @xiaoxiang781216,  @acassis sorry, my push dismissed your approvals.
   Could you take a look again when you have time?
   
   Thanks :)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to