HedongGao commented on PR #21501:
URL: https://github.com/apache/nuttx/pull/21501#issuecomment-7075226555

   Rebased onto the latest master to resolve conflicts with the PHYLIB 
framework (64e4d571ce3).
   
   - `include/nuttx/net/netdev_lowerhalf.h`, `include/nuttx/ethtool.h`: kept 
the new PHYLIB declarations and structures, and placed the channel declarations 
and structures next to them.
   - `drivers/net/netdev_upperhalf.c`: `netdev_upper_ioctl()` now tries 
`phy_ioctl()` first and then the `eth_ops` handler. The ethtool handler only 
returns when the result is not `-ENOTTY`, like the other handlers in this 
function. Before this change it returned unconditionally, so if it ran before 
`phy_ioctl()`, link-settings commands such as `ETHTOOL_GLINKSETTINGS` would 
never reach PHYLIB.
   
   Testing: `./tools/checkpatch.sh -c -u -m -g` passes. `sim:tcpblaster` with 
`CONFIG_NETDEV_ETHTOOL_IOCTL=y`, `CONFIG_MDIO_BUS=y` and `CONFIG_NET_PHYLIB=y` 
builds without warnings.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to