v01d commented on a change in pull request #2222:
URL: https://github.com/apache/incubator-nuttx/pull/2222#discussion_r520639363
##########
File path: arch/arm/src/lpc214x/lpc214x_serial.c
##########
@@ -89,7 +90,7 @@ static int up_attach(struct uart_dev_s *dev);
static void up_detach(struct uart_dev_s *dev);
static int up_interrupt(int irq, void *context, void *arg);
static int up_ioctl(struct file *filep, int cmd, unsigned long arg);
-static int up_receive(struct uart_dev_s *dev, uint32_t *status);
+static int up_receive(struct uart_dev_s *dev, unsigned int *status);
Review comment:
Well, what I meant is that in some architectures (for example, nRF52)
uint32_t is the type used to handle register values and not unsigned int.
Similarly, for 16 bit values you can see uint16_t used extensively, instead of
unsigned short.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
