xiaoxiang781216 commented on pull request #2418: URL: https://github.com/apache/incubator-nuttx/pull/2418#issuecomment-735658510
> > i'm not sure if it's safe to make them an enum. as they are mostly used as int in the tree. just a vague concern. > > The most correct thing to do would be to remove the definitions of OK and ERROR and replace them with 0 and -1 as required by specifications. OK and ERROR are not standard and not portable and best not a part of the OS > @patacongo do you want to replace all OK/ERROR to 0/-1? If yes, I can try. > Unfortunately, the use of OK and ERROR is pervasive and would be awkward to remove. Or, take this patch to limit OK/ERROR damage scope. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
