fjpanag opened a new pull request #2477: URL: https://github.com/apache/incubator-nuttx/pull/2477
## Summary On STM32F2xx & STM32F4xx there is configuration for the FLASH wait cycles. This configuration depends both on system clock, and the MCU voltage input. Previously the code assumed that all MCU's are powered with their maximum voltage (3.3V), thus systems with lower voltage were not configured correctly. ## Impact There is no impact on typical system, running on the nominal voltage (3.3V). However if someone was to use a lower voltage, the FLASH was configured incorrectly, and I would expect errors like corrupted reads etc. This PR will handle such cases. Also note that in the previous implementation, there were no indication to a user that the system was miss-configured. Now there is a need for a new definition in `board.h`. This will probably break custom boards, but it will be a good indication that Vin is important and that it affects the FLASH operation. ## Testing Not much for the moment. I plan to check that at least some configurations build correctly. I will surely run the code on an STM32F427-based board, confirming that the configuration is correct for various Vin settings. --- There may be nxstyle issues that I will fix in a dedicated commit. Also, this new definition is needed to be added to all relevant `board.h` files. Please review the actual RCC changes, and I will and the other boards soon. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
