btashton commented on issue #2478: URL: https://github.com/apache/incubator-nuttx/issues/2478#issuecomment-738911174
I started making this fix, and had a couple questions. It looks like we also remove these from all the `arch/arm/<chip>/Make.defs` as this will come in via libs now? Is there anything special that needs to happen here? ``` ifeq ($(CONFIG_ARCH_SETJMP_H),y) ifeq ($(CONFIG_ARCH_TOOLCHAIN_GNU),y) CMN_ASRCS += arm_setjmp.S endif endif ``` `arch/sim/src/sim/up_setjmp_arm.S` -- Why is this here? I would not expect arm specific code in the sim. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org