yamt commented on pull request #695: URL: https://github.com/apache/incubator-nuttx-apps/pull/695#issuecomment-837530925
> > the "defensive" style can make it difficult to find such bugs. > > @yamt It doesn't make sense. If you are following the recommended mitigation methods and therefore preventing these bugs from happening, which bugs are you expecting to find then? unintended uses of values. > > > i certainly don't recommend to apply the method blindly. > > (i feel it "blindly" because you are suggesting to add "ctx->ws = NULL" even in a place where it's already known to be NULL.) > > Indeed, one of the issues I've raised is actually wrong and I acknowledge my mistake. However, my review process is far from being considered "blind", and that was an unfortunate statement of yours. sorry if you felt that way. i have no intention to attack you. "blind" might have been an inappropriate word. maybe "mechanical"? > By the way, instead of undervaluing the reviewer's methods, please explain clearly on why an issue is not valid. If I am still wrong on the other raised issues, I'd like to learn from them. if the code is bug-free, the value doesn't matter. they should not be used by anyone. thus those NULLify should not be necessary. if there is a bug (i guess there is :-) i prefer it fails loudly. that's why i generally don't like the "defensive" methods. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected]
