xiaoxiang781216 commented on a change in pull request #3755:
URL: https://github.com/apache/incubator-nuttx/pull/3755#discussion_r642248466
##########
File path: net/icmp/icmp_recvmsg.c
##########
@@ -389,111 +389,114 @@ ssize_t icmp_recvmsg(FAR struct socket *psock, FAR
struct msghdr *msg,
goto errout;
Review comment:
net_unlock shouldn't be called here.
##########
File path: net/icmp/icmp_recvmsg.c
##########
@@ -389,111 +389,114 @@ ssize_t icmp_recvmsg(FAR struct socket *psock, FAR
struct msghdr *msg,
goto errout;
}
+ /* Get the device that was used to send the ICMP request. */
+
+ dev = conn->dev;
+ DEBUGASSERT(dev != NULL);
+ if (dev == NULL)
+ {
+ ret = -EPROTO;
+ goto errout;
Review comment:
net_unlock shouldn't be called here.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
