davids5 commented on pull request #3738: URL: https://github.com/apache/incubator-nuttx/pull/3738#issuecomment-856923104
> > @xiaoxiang781216 I am doing a sync with upstream... Getting lots of > > `more undefined references to`DEBUGASSERT' follow` > > Was the method to move the include to all the source files as apposed to a a common header file (like nsh.h" for all nsh)? > > Yes, we can add assert.h into an internal header file to avoid the repeat inclusion, but this file shouldn't be inside nuttx/include. > > > What was the way you tested this? > > Pass the CI, but some source files may be skipped as you found since they aren't enable to compiled by any defconfig. > > > ``` > > find ../ | xargs grep -l -s DEBUGASSERT | xargs grep -L -E 'assert.h|cassert' > > ../apps/netutils/netlib/netlib_getroute.c > > ../apps/fsutils/ipcfg/ipcfg_text.c > > ../apps/industry/foc/fixed16/foc_velocity.c > > ../apps/industry/foc/float/foc_velocity.c > > ``` > > I will create new patch to fix these files. @xiaoxiang781216 - thanks - I had some WIP not listed above. Now in PR #3874 and https://github.com/apache/incubator-nuttx-apps/pull/753 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected]
