xiaoxiang781216 edited a comment on pull request #4193: URL: https://github.com/apache/incubator-nuttx/pull/4193#issuecomment-884984681
> > > It should be done and fully tested on real HW before it comes in to master. > > > Event the printf change will increase code size with FS_LARGEFILE off. > > > Why? I don't see any reason that the code size if FS_LARGEFILE off. Could you explain more? > > 1953165 - 1953157 = 8 > > This is about code space and useless bloat. If it is Off it need to cost 0 The difference you identify is due to the cast in syslog, I can add #if/#else/#endif in the code, but all these places are the debugging log, do you think it's worth to make the code like spaghetti to save several bytes(especially if we consider that the debuging log already consume much more memory than the production code). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
