gustavonihei commented on a change in pull request #4334:
URL: https://github.com/apache/incubator-nuttx/pull/4334#discussion_r687828297
##########
File path: arch/risc-v/src/esp32c3/Kconfig
##########
@@ -261,6 +261,10 @@ config ESP32C3_SPIFLASH
select MTD_BYTE_WRITE
select MTD_PARTITION
+config ESP32C3_SPIFLASH_BLOCK_SIZE
+ int "SPI FLASH BLOCK SIZE"
+ default 64
Review comment:
The flash block size is not configurable, so it is wrong to create a
configuration for it.
The `MTD_BLKSIZE` macro retrieves this info from the `page_size` field which
is configured by the bootloader depending on the underlying SPI Flash IC
present on the module.
It seems that, instead of doing this change on the driver, the correct
approach would be to configure the scale factor on LittleFS accordingly (the
'CONFIG_FS_LITTLEFS_BLOCK_FACTOR` proposed in #4330).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
