gustavonihei commented on a change in pull request #4585:
URL: https://github.com/apache/incubator-nuttx/pull/4585#discussion_r714199524
##########
File path: boards/xtensa/esp32s2/esp32s2-saola-1/src/esp32s2_bringup.c
##########
@@ -154,6 +158,15 @@ int esp32s2_bringup(void)
#endif /* CONFIG_TIMER */
+#ifdef CONFIG_ESP32S2_RT_TIMER
+ ret = esp32s2_rt_timer_init();
+ if (ret < 0)
+ {
+ syslog(LOG_ERR, "Failed to initialize RT timer: %d\n", ret);
+ return ret;
Review comment:
```suggestion
```
Even if the RT Timer initialization fails, the bringup function should not
return early.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
