xiaoxiang781216 commented on a change in pull request #4814:
URL: https://github.com/apache/incubator-nuttx/pull/4814#discussion_r746208839



##########
File path: net/can/can_recvmsg.c
##########
@@ -622,7 +623,14 @@ ssize_t can_recvmsg(FAR struct socket *psock, FAR struct 
msghdr *msg,
    * socket has been disconnected.
    */
 
+  /* The following operations must be performed with interrupts
+   * disabled because iob_tryadd_queue() may be called from an interrupt

Review comment:
       iob_tryalloc_qentry already hold critical section, why we need hold here 
again?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to