a-lunev commented on a change in pull request #5239:
URL: https://github.com/apache/incubator-nuttx/pull/5239#discussion_r785457753
##########
File path: net/tcp/tcp_sendfile.c
##########
@@ -495,6 +495,9 @@ ssize_t tcp_sendfile(FAR struct socket *psock, FAR struct
file *infile,
*/
net_lock();
+#ifdef CONFIG_NET_TCP_WRITE_BUFFERS
+ conn->sendfile = true;
Review comment:
This PR (#5239) and PR #5138 are unrelated issues.
Concerning PR #5138 there is another situation. I expect that controlling
sndseq can be done the same way (unified) without dependence on
CONFIG_NET_TCP_WRITE_BUFFERS option. So far I have not touched the buffered
mode concerning sndseq control as it seems working. However, I'm going to
consider unification of how sndseq is controlled as well.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
