pkarashchenko commented on pull request #5244: URL: https://github.com/apache/incubator-nuttx/pull/5244#issuecomment-1015917754
> > @pkarashchenko Only this can apply the change: > > https://github.com/apache/incubator-nuttx/pull/5244/files#diff-5231c6d2bc4bea5e569bd0bbf5d3d8cee0b1f4cfa6492bed180a07622ab0f2deR36 > > > > > > > @xiaoxiang781216 what is the problem of having `-fno-strength-reduce` with > > > > > > ``` > > > config DEBUG_NOOPT > > > bool "Suppress Optimization" > > > ---help--- > > > Build without optimization. This is often helpful when debugging code. > > > ``` > > > > > > ? Or you just want to say that strength reduction does not influence on debugging experience in general? > > > > I am enabling clang toolchain, and the compiler emit a warning message for each source file since -fno-strength-reduce` doesn't support by clang yet. So, it's simple to remove this option from Make.defs. > > Understood. I think it is fine to remove it, but in general flags are different in GCC, Clang and IAR, so if we would like to support multiple compilers for the same target, then probably it is good to think about flags definition depending on selected compiler. @xiaoxiang781216 the proper PR description would help to understand such changes better in the future. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
