pkarashchenko commented on a change in pull request #5282:
URL: https://github.com/apache/incubator-nuttx/pull/5282#discussion_r788764505
##########
File path: boards/risc-v/bl602/bl602evb/scripts/Make.defs
##########
@@ -45,8 +45,8 @@ ifneq ($(CONFIG_DEBUG_NOOPT),y)
endif
ARCHCPUFLAGS += -mno-relax
-ARCHCFLAGS = -fno-builtin -ffunction-sections -fdata-sections
-fstrict-volatile-bitfields -fshort-enums -fno-omit-frame-pointer
-ARCHCXXFLAGS = -fno-builtin -ffunction-sections -fdata-sections
-fstrict-volatile-bitfields -fshort-enums -fno-omit-frame-pointer
-fno-exceptions -fcheck-new -std=c++17 -D__NuttX__ -pipe -nostdinc++
+ARCHCFLAGS = -fno-builtin -ffunction-sections -fdata-sections
Review comment:
General question on `-fshort-enums`. Shouldn't this give better code
size?
Do we have a Kconfig options to specify extra options like this? It might be
needed if code is linked to third party pre-compiled libraries that are
compiled with `-fshort-enums` and have pointers to enums or arrays of enums
passed as parameters to functions.
##########
File path: boards/xtensa/esp32s2/esp32s2-saola-1/scripts/Make.defs
##########
@@ -54,7 +54,7 @@ ifneq ($(CONFIG_DEBUG_NOOPT),y)
ARCHOPTIMIZATION += $(MAXOPTIMIZATION) -fno-strict-aliasing
endif
-ARCHCFLAGS = -fno-builtin -ffunction-sections -fdata-sections
-fstrict-volatile-bitfields -mlongcalls
+ARCHCFLAGS = -fno-builtin -ffunction-sections -fdata-sections -mlongcalls
Review comment:
Do we need to add `ifeq ($(CONFIG_FRAME_POINTER),y)`?
##########
File path: boards/xtensa/esp32/esp32-wrover-kit/scripts/Make.defs
##########
@@ -73,7 +73,7 @@ ifneq ($(CONFIG_DEBUG_NOOPT),y)
ARCHOPTIMIZATION += $(MAXOPTIMIZATION) -fno-strict-aliasing
endif
-ARCHCFLAGS = -fno-builtin -ffunction-sections -fdata-sections
-fstrict-volatile-bitfields -mlongcalls
+ARCHCFLAGS = -fno-builtin -ffunction-sections -fdata-sections -mlongcalls
Review comment:
Do we need to add `ifeq ($(CONFIG_FRAME_POINTER),y)`?
##########
File path: boards/sparc/bm3823/xx3823/scripts/Make.defs
##########
@@ -55,7 +55,7 @@ ifeq ($(CONFIG_DEBUG_SYMBOLS),y)
endif
ifneq ($(CONFIG_DEBUG_NOOPT),y)
- ARCHOPTIMIZATION += $(MAXOPTIMIZATION) -fno-strict-aliasing
-fomit-frame-pointer
+ ARCHOPTIMIZATION += $(MAXOPTIMIZATION) -fno-strict-aliasing
Review comment:
Do we need to add `ifeq ($(CONFIG_FRAME_POINTER),y)`?
##########
File path: boards/xtensa/esp32/esp32-devkitc/scripts/Make.defs
##########
@@ -73,7 +73,7 @@ ifneq ($(CONFIG_DEBUG_NOOPT),y)
ARCHOPTIMIZATION += $(MAXOPTIMIZATION) -fno-strict-aliasing
endif
-ARCHCFLAGS = -fno-builtin -ffunction-sections -fdata-sections
-fstrict-volatile-bitfields -mlongcalls
+ARCHCFLAGS = -fno-builtin -ffunction-sections -fdata-sections -mlongcalls
Review comment:
Do we need to add `ifeq ($(CONFIG_FRAME_POINTER),y)`?
##########
File path: boards/xtensa/esp32/ttgo_lora_esp32/scripts/Make.defs
##########
@@ -73,7 +73,7 @@ ifneq ($(CONFIG_DEBUG_NOOPT),y)
ARCHOPTIMIZATION += $(MAXOPTIMIZATION) -fno-strict-aliasing
endif
-ARCHCFLAGS = -fno-builtin -ffunction-sections -fdata-sections
-fstrict-volatile-bitfields -mlongcalls
+ARCHCFLAGS = -fno-builtin -ffunction-sections -fdata-sections -mlongcalls
Review comment:
Do we need to add `ifeq ($(CONFIG_FRAME_POINTER),y)`?
##########
File path: boards/xtensa/esp32/esp32-ethernet-kit/scripts/Make.defs
##########
@@ -73,7 +73,7 @@ ifneq ($(CONFIG_DEBUG_NOOPT),y)
ARCHOPTIMIZATION += $(MAXOPTIMIZATION) -fno-strict-aliasing
endif
-ARCHCFLAGS = -fno-builtin -ffunction-sections -fdata-sections
-fstrict-volatile-bitfields -mlongcalls
+ARCHCFLAGS = -fno-builtin -ffunction-sections -fdata-sections -mlongcalls
Review comment:
Do we need to add `ifeq ($(CONFIG_FRAME_POINTER),y)`?
##########
File path: boards/sparc/bm3803/xx3803/scripts/Make.defs
##########
@@ -55,7 +55,7 @@ ifeq ($(CONFIG_DEBUG_SYMBOLS),y)
endif
ifneq ($(CONFIG_DEBUG_NOOPT),y)
- ARCHOPTIMIZATION += $(MAXOPTIMIZATION) -fno-strict-aliasing
-fomit-frame-pointer
+ ARCHOPTIMIZATION += $(MAXOPTIMIZATION) -fno-strict-aliasing
Review comment:
Do we need to add `ifeq ($(CONFIG_FRAME_POINTER),y)` case here?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
