masayuki2009 commented on a change in pull request #5485:
URL: https://github.com/apache/incubator-nuttx/pull/5485#discussion_r806327482
##########
File path: arch/arm/src/rtl8720c/Toolchain.defs
##########
@@ -50,8 +50,8 @@ ifneq ($(CONFIG_ARMV8M_STACKCHECK),y)
endif
endif
-ARCHCFLAGS = -fno-builtin -march=armv8-m.main+dsp -mthumb -mfloat-abi=soft
-D__thumb2__ -g -gdwarf-3 -Os -fno-tree-scev-cprop
-ARCHCXXFLAGS = -fno-builtin -nostdinc++ -std=c++11
+ARCHCFLAGS = -fno-builtin -march=armv8-m.main+dsp -mthumb -mfloat-abi=soft
-D__thumb2__ -g -gdwarf-3 -Os -fno-tree-scev-cprop -fno-common
Review comment:
@pkarashchenko
Do you mean that `-fno-common` should be moved to `ARCHOPTIMIZATION`
or `-ffunction-sections -fdata-sections` should be moved to
`ARCHCFLAGS/ARCHCXXFLAGS` ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
