xiaoxiang781216 commented on a change in pull request #5496: URL: https://github.com/apache/incubator-nuttx/pull/5496#discussion_r807529757
########## File path: arch/common/src/Makefile ########## @@ -0,0 +1,27 @@ +############################################################################ +# arch/common/src/Makefile +# +# Licensed to the Apache Software Foundation (ASF) under one or more +# contributor license agreements. See the NOTICE file distributed with +# this work for additional information regarding copyright ownership. The +# ASF licenses this file to you under the Apache License, Version 2.0 (the +# "License"); you may not use this file except in compliance with the +# License. You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, software +# distributed under the License is distributed on an "AS IS" BASIS, WITHOUT +# WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the +# License for the specific language governing permissions and limitations +# under the License. +# +############################################################################ + +# Linker Scripts + +ifeq ($(CONFIG_CYGWIN_WINTOOL),y) +LDFLAGS += $(addprefix -T,$(foreach SCRIPT,$(ARCHSCRIPT),${shell cygpath -w $(SCRIPT)})) Review comment: it's strange that the common folder just have one script file, how about we add a make function in Config.mk to extend the path with cygpath conditionally, and invoke that function like this: ``` LDFLAGS += $(addprefix -T $(xxx, $(ARCHSCRIPT))) ``` The new function can be used in many similar place. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
