no1wudi commented on a change in pull request #1021: URL: https://github.com/apache/incubator-nuttx-apps/pull/1021#discussion_r810830342
########## File path: examples/hello_rust/hello_rust_main.rs ########## @@ -33,6 +40,20 @@ extern "C" pub fn printf(format: *const u8, ...) -> i32; } +/**************************************************************************** + * Private functions + ****************************************************************************/ + +/**************************************************************************** + * Panic handler (needed for [no_std] compilation) Review comment: > > May I ask you to provide more details, so we can go a step ahead on this point: > > * Is there a good official documentation on the Rust style, we can reference in NuttX? Please refer to https://doc.rust-lang.org/reference/comments.html, there are doc comments and non-doc comments. > * Can we check this, similar to checkpatch.sh and can be used in CI? Please refer https://lore.kernel.org/rust-for-linux/yo3vijpacsznn...@moria.home.lan/T, may rustfmtcheck will help you. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org