acassis commented on a change in pull request #5585:
URL: https://github.com/apache/incubator-nuttx/pull/5585#discussion_r811943381
##########
File path: mm/mm_heap/mm.h
##########
@@ -64,28 +66,45 @@
* REVISIT: We could do better on machines with 16-bit addressing.
*/
-# define MM_MIN_SHIFT ( 4) /* 16 bytes */
-# define MM_MAX_SHIFT (15) /* 32 Kb */
+# define MM_MIN_SHIFT_ ( 4) /* 16 bytes */
Review comment:
```suggestion
# define MM_MIN_SHIFT ( 4) /* 16 bytes */
```
##########
File path: mm/mm_heap/mm.h
##########
@@ -64,28 +66,45 @@
* REVISIT: We could do better on machines with 16-bit addressing.
*/
-# define MM_MIN_SHIFT ( 4) /* 16 bytes */
-# define MM_MAX_SHIFT (15) /* 32 Kb */
+# define MM_MIN_SHIFT_ ( 4) /* 16 bytes */
+# define MM_MAX_SHIFT (15) /* 32 Kb */
#elif defined(CONFIG_HAVE_LONG_LONG)
/* Four byte offsets; Pointers may be 4 or 8 bytes
* sizeof(struct mm_freenode_s) is 16 or 24 bytes.
*/
# if UINTPTR_MAX <= UINT32_MAX
-# define MM_MIN_SHIFT ( 4) /* 16 bytes */
+# define MM_MIN_SHIFT_ ( 4) /* 16 bytes */
Review comment:
```suggestion
# define MM_MIN_SHIFT ( 4) /* 16 bytes */
```
##########
File path: mm/mm_heap/mm.h
##########
@@ -64,28 +66,45 @@
* REVISIT: We could do better on machines with 16-bit addressing.
*/
-# define MM_MIN_SHIFT ( 4) /* 16 bytes */
-# define MM_MAX_SHIFT (15) /* 32 Kb */
+# define MM_MIN_SHIFT_ ( 4) /* 16 bytes */
+# define MM_MAX_SHIFT (15) /* 32 Kb */
#elif defined(CONFIG_HAVE_LONG_LONG)
/* Four byte offsets; Pointers may be 4 or 8 bytes
* sizeof(struct mm_freenode_s) is 16 or 24 bytes.
*/
# if UINTPTR_MAX <= UINT32_MAX
-# define MM_MIN_SHIFT ( 4) /* 16 bytes */
+# define MM_MIN_SHIFT_ ( 4) /* 16 bytes */
# elif UINTPTR_MAX <= UINT64_MAX
-# define MM_MIN_SHIFT ( 5) /* 32 bytes */
+# define MM_MIN_SHIFT_ ( 5) /* 32 bytes */
Review comment:
```suggestion
# define MM_MIN_SHIFT ( 5) /* 32 bytes */
```
##########
File path: mm/mm_heap/mm.h
##########
@@ -64,28 +66,45 @@
* REVISIT: We could do better on machines with 16-bit addressing.
*/
-# define MM_MIN_SHIFT ( 4) /* 16 bytes */
-# define MM_MAX_SHIFT (15) /* 32 Kb */
+# define MM_MIN_SHIFT_ ( 4) /* 16 bytes */
+# define MM_MAX_SHIFT (15) /* 32 Kb */
#elif defined(CONFIG_HAVE_LONG_LONG)
/* Four byte offsets; Pointers may be 4 or 8 bytes
* sizeof(struct mm_freenode_s) is 16 or 24 bytes.
*/
# if UINTPTR_MAX <= UINT32_MAX
-# define MM_MIN_SHIFT ( 4) /* 16 bytes */
+# define MM_MIN_SHIFT_ ( 4) /* 16 bytes */
# elif UINTPTR_MAX <= UINT64_MAX
-# define MM_MIN_SHIFT ( 5) /* 32 bytes */
+# define MM_MIN_SHIFT_ ( 5) /* 32 bytes */
# endif
-# define MM_MAX_SHIFT (22) /* 4 Mb */
+# define MM_MAX_SHIFT (22) /* 4 Mb */
#else
/* Four byte offsets; Pointers must be 4 bytes.
* sizeof(struct mm_freenode_s) is 16 bytes.
*/
-# define MM_MIN_SHIFT ( 4) /* 16 bytes */
-# define MM_MAX_SHIFT (22) /* 4 Mb */
+# define MM_MIN_SHIFT_ ( 4) /* 16 bytes */
Review comment:
```suggestion
# define MM_MIN_SHIFT ( 4) /* 16 bytes */
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
