[GitHub] [incubator-nuttx] pkarashchenko commented on a change in pull request #5589: net/tcp(buffered): retransmit only one the earliest not acknowledged segment

[GitBox]

pkarashchenko commented on a change in pull request #5589:
URL: https://github.com/apache/incubator-nuttx/pull/5589#discussion_r812973119



##########
File path: net/tcp/tcp_send_buffered.c
##########
@@ -796,7 +741,7 @@ static uint16_t psock_send_eventhandler(FAR struct 
net_driver_s *dev,
    */
 
   if ((conn->tcpstateflags & TCP_ESTABLISHED) &&

Review comment:
       ```suggestion
     if ((conn->tcpstateflags & TCP_ESTABLISHED) != 0 &&
   ```

##########
File path: net/tcp/tcp_send_buffered.c
##########
@@ -796,7 +741,7 @@ static uint16_t psock_send_eventhandler(FAR struct 
net_driver_s *dev,
    */
 
   if ((conn->tcpstateflags & TCP_ESTABLISHED) &&
-      (flags & (TCP_POLL | TCP_REXMIT)) &&
+      (flags & TCP_POLL) &&

Review comment:
       ```suggestion
         (flags & TCP_POLL) != 0 &&
   ```




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org