xiaoxiang781216 commented on a change in pull request #1044:
URL:
https://github.com/apache/incubator-nuttx-apps/pull/1044#discussion_r820240591
##########
File path: system/nxplayer/nxplayer.c
##########
@@ -148,7 +148,7 @@ static int _open_with_http(const char *fullurl)
char resp_msg[] = "\r\n\r\n";
struct timeval tv;
uint16_t port = 80;
- char buf[64];
+ char buf[256];
Review comment:
Yes, but MAX_PATH is safe value, since the format string add more char
to relurl:
```
snprintf(buf, sizeof(buf), "GET /%s HTTP/1.0\r\n\r\n", relurl);
```
it's hard and unnecessary to calculate the real size.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
