pkarashchenko commented on a change in pull request #5204:
URL: https://github.com/apache/incubator-nuttx/pull/5204#discussion_r822061271



##########
File path: drivers/input/button_upper.c
##########
@@ -887,7 +801,6 @@ int btn_register(FAR const char *devname,
   return OK;
 
 errout_with_priv:

Review comment:
       I think we can remove `errout_with_priv` here and just `kmm_free(priv);` 
in `if (ret < 0)` instead.

##########
File path: drivers/input/ajoystick.c
##########
@@ -835,7 +748,6 @@ int ajoy_register(FAR const char *devname,
   return OK;
 
 errout_with_priv:

Review comment:
       I think we can remove `errout_with_priv` here and just `kmm_free(priv);` 
in `if (ret < 0)` instead.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


Reply via email to