xiaoxiang781216 commented on a change in pull request #5706:
URL: https://github.com/apache/incubator-nuttx/pull/5706#discussion_r823292475
##########
File path: arch/arm/src/armv7-a/arm_syscall.c
##########
@@ -238,7 +238,9 @@ uint32_t *arm_syscall(uint32_t *regs)
* set will determine the restored context.
*/
+#if defined(CONFIG_ARCH_FPU)
Review comment:
don't need since arm_restorefpu become the empty macro if
CONFIG_ARCH_FPU isn't defined
##########
File path: arch/arm/src/armv7-a/arm_syscall.c
##########
@@ -266,9 +268,8 @@ uint32_t *arm_syscall(uint32_t *regs)
#if defined(CONFIG_ARCH_FPU)
arm_copyarmstate((uint32_t *)regs[REG_R1], regs);
arm_restorefpu((uint32_t *)regs[REG_R2]);
-#else
- memcpy((uint32_t *)regs[REG_R1], regs, XCPTCONTEXT_SIZE);
#endif
+ memcpy((uint32_t *)regs[REG_R1], regs, XCPTCONTEXT_SIZE);
Review comment:
arm_copyarmstate already do the copy?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
