pkarashchenko commented on pull request #5705: URL: https://github.com/apache/incubator-nuttx/pull/5705#issuecomment-1063954851
> As far as I can tell, these specific options (like `BOARD_STM32_COMMON`) are used only in the common folder's Kconfig file to select the source files to build. Wouldn't be better to just replace it with this new config? We won't have to add other chips options and we won't have to deal with this every-time we introduce the common folder for a family. The specific options (like `BOARD_STM32_COMMON`) are used by in-tree configs. The in-tree board common is mapped via `$(wildcard $(BOARD_DIR)$(DELIM)..$(DELIM)common)` and not via `$(wildcard $(TOPDIR)$(DELIM)boards$(DELIM)$(CONFIG_ARCH)$(DELIM)$(CONFIG_ARCH_CHIP)$(DELIM)common)`, so with current code we can't eliminate `specific options (like `BOARD_STM32_COMMON`)` because `$(wildcard $(BOARD_DIR)$(DELIM)..$(DELIM)common)` will always exists for STM32 based in-tree boards. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
