pkarashchenko commented on a change in pull request #5729:
URL: https://github.com/apache/incubator-nuttx/pull/5729#discussion_r825361954
##########
File path: arch/xtensa/src/common/xtensa_int_handlers.S
##########
@@ -768,13 +756,13 @@ _xtensa_level6_handler:
/* Restore only level-specific regs (the rest were already restored) */
- l32i a0, a2, (4 * REG_PS) /* Retrieve
interruptee's PS */
+ l32i a0, a2, (4 * REG_PS) /* Retrieve interruptee's PS */
wsr a0, EPS_6
- l32i a0, a2, (4 * REG_PC) /* Retrieve
interruptee's PC */
+ l32i a0, a2, (4 * REG_PC) /* Retrieve interruptee's PC */
wsr a0, EPC_6
- l32i a0, a2, (4 * REG_A0) /* Retrieve
interruptee's A0 */
- l32i sp, a2, (4 * REG_A1) /* Remove interrupt
stack frame */
- l32i a2, a2, (4 * REG_A2) /* Retrieve
interruptee's A2 */
+ l32i a0, a2, (4 * REG_A0) /* Retrieve interruptee's A0 */
+ l32i sp, a2, (4 * REG_A1) /* Retrieve interrupt stack frame */
+ l32i a2, a2, (4 * REG_A2) /* Retrieve interruptee's A2 */
Review comment:
```suggestion
l32i a0, a2, (4 * REG_A0) /* Retrieve
interruptee's A0 */
l32i sp, a2, (4 * REG_A1) /* Retrieve interrupt
stack frame */
l32i a2, a2, (4 * REG_A2) /* Retrieve
interruptee's A2 */
```
##########
File path: arch/xtensa/src/common/xtensa_int_handlers.S
##########
@@ -768,13 +756,13 @@ _xtensa_level6_handler:
/* Restore only level-specific regs (the rest were already restored) */
- l32i a0, a2, (4 * REG_PS) /* Retrieve
interruptee's PS */
+ l32i a0, a2, (4 * REG_PS) /* Retrieve interruptee's PS */
wsr a0, EPS_6
- l32i a0, a2, (4 * REG_PC) /* Retrieve
interruptee's PC */
+ l32i a0, a2, (4 * REG_PC) /* Retrieve interruptee's PC */
Review comment:
```suggestion
l32i a0, a2, (4 * REG_PC) /* Retrieve
interruptee's PC */
```
##########
File path: arch/xtensa/src/common/xtensa_user_handler.S
##########
@@ -299,8 +297,8 @@ _xtensa_user_handler:
l32i a0, a2, (4 * REG_PC) /* Retrieve
interruptee's PC */
wsr a0, EPC_1
l32i a0, a2, (4 * REG_A0) /* Retrieve
interruptee's A0 */
- l32i sp, a2, (4 * REG_A1) /* Remove interrupt
stack frame */
- l32i a2, a2, (4 * REG_A2) /* Retrieve
interruptee's A2 */
+ l32i sp, a2, (4 * REG_A1) /* Retrieve interrupt
stack frame */
+ l32i a2, a2, (4 * REG_A2) /* Retrieve interruptee's A2
*/
Review comment:
```suggestion
l32i a2, a2, (4 * REG_A2) /* Retrieve
interruptee's A2 */
```
##########
File path: arch/xtensa/src/common/xtensa_int_handlers.S
##########
@@ -768,13 +756,13 @@ _xtensa_level6_handler:
/* Restore only level-specific regs (the rest were already restored) */
- l32i a0, a2, (4 * REG_PS) /* Retrieve
interruptee's PS */
+ l32i a0, a2, (4 * REG_PS) /* Retrieve interruptee's PS */
Review comment:
```suggestion
l32i a0, a2, (4 * REG_PS) /* Retrieve
interruptee's PS */
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
