xiaoxiang781216 commented on a change in pull request #5829:
URL: https://github.com/apache/incubator-nuttx/pull/5829#discussion_r832979072
##########
File path: libs/libc/machine/risc-v/common/arch_elf.c
##########
@@ -343,7 +343,7 @@ int up_relocateadd(FAR const Elf_Rela *rel, FAR const
Elf_Sym *sym,
addr, _get_val((uint16_t *)addr),
sym, sym->st_value);
- offset = (long)sym->st_value - (long)addr;
Review comment:
should we change offset type to uintptr_t, and remove all (long) castt?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
