pkarashchenko commented on a change in pull request #5848:
URL: https://github.com/apache/incubator-nuttx/pull/5848#discussion_r835792487
##########
File path: net/local/local_sockif.c
##########
@@ -718,6 +718,17 @@ static int local_ioctl(FAR struct socket *psock, int cmd,
switch (cmd)
{
+ case FIONBIO:
+ if (conn->lc_infile.f_inode != NULL)
+ {
+ ret = file_ioctl(&conn->lc_infile, cmd, arg);
+ }
+
+ if (conn->lc_outfile.f_inode != NULL)
+ {
+ ret = file_ioctl(&conn->lc_outfile, cmd, arg);
+ }
Review comment:
```suggestion
if (conn->lc_infile.f_inode != NULL)
{
ret = file_ioctl(&conn->lc_infile, cmd, arg);
}
else if (conn->lc_outfile.f_inode != NULL)
{
ret = file_ioctl(&conn->lc_outfile, cmd, arg);
}
else
{
ret = -ENOTCONN;
}
```
I'm not sure if that is correct, but returning `OK` if both
`conn->lc_infile.f_inode` and `conn->lc_outfile.f_inode` are NULL seems not
correct to me.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
