pkarashchenko commented on a change in pull request #5897:
URL: https://github.com/apache/incubator-nuttx/pull/5897#discussion_r837243901
##########
File path: arch/xtensa/src/lx6/Toolchain.defs
##########
@@ -55,8 +59,15 @@ else
MAXOPTIMIZATION += -fomit-frame-pointer
endif
-ifeq ($(CONFIG_MM_KASAN),y)
- ARCHCPUFLAGS += -fsanitize=kernel-address
+ARCHCFLAGS = -mlongcalls
+ARCHCXXFLAGS = -mlongcalls
Review comment:
So why `-mlongcalls` was not needed before?
##########
File path: boards/risc-v/esp32c3/esp32c3-devkit/scripts/Make.defs
##########
@@ -41,8 +41,8 @@ ifneq ($(CONFIG_DEBUG_NOOPT),y)
ARCHOPTIMIZATION += $(MAXOPTIMIZATION) -fno-strict-aliasing
endif
-ARCHCFLAGS = -fno-common -ffunction-sections -fdata-sections
-msmall-data-limit=0
-ARCHCXXFLAGS = $(ARCHCFLAGS) -fno-exceptions -fcheck-new -fno-rtti
+ARCHCFLAGS += -fno-common -ffunction-sections -fdata-sections
-msmall-data-limit=0
+ARCHCXXFLAGS += -fno-common -ffunction-sections -fdata-sections
-msmall-data-limit=0 -std=c++17
Review comment:
I was almost starting to do the opposite change and do `ARCHCXXFLAGS +=
$(ARCHCFLAGS) ....` for all the platforms as sometimes `-fno-common
-ffunction-sections -fdata-sections` are not added to `ARCHCXXFLAGS`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
