raiden00pl commented on code in PR #6057:
URL: https://github.com/apache/incubator-nuttx/pull/6057#discussion_r851161126
##########
net/can/can_recvmsg.c:
##########
@@ -410,8 +410,7 @@ static uint16_t can_recvfrom_eventhandler(FAR struct
net_driver_s *dev,
FAR void *pvpriv, uint16_t flags)
{
struct can_recvfrom_s *pstate = (struct can_recvfrom_s *)pvpriv;
-#if (defined(CONFIG_NET_CANPROTO_OPTIONS) && defined(CONFIG_NET_CAN_CANFD)) ||
\
- defined(CONFIG_NET_TIMESTAMP)
Review Comment:
This'll cause CI fail for b-g431b-esc1/cansock configuration:
> Error: can/can_recvmsg.c:415:22: error: unused variable 'conn'
[-Werror=unused-variable]
> 415 | struct can_conn_s *conn = (struct can_conn_s
*)pstate->pr_sock->s_conn;
> | ^~~~
Probably we should modify this condition to just:
`#if defined(CONFIG_NET_CANPROTO_OPTIONS) || defined(CONFIG_NET_TIMESTAMP)
`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
