PetervdPerk-NXP commented on code in PR #6057: URL: https://github.com/apache/incubator-nuttx/pull/6057#discussion_r858471777
########## include/nuttx/net/ioctl.h: ########## @@ -112,8 +112,12 @@ /* SocketCAN ****************************************************************/ -#define SIOCGCANBITRATE _SIOC(0x002C) /* Get bitrate from a CAN controller */ -#define SIOCSCANBITRATE _SIOC(0x002D) /* Set bitrate of a CAN controller */ +#define SIOCGCANBITRATE _SIOC(0x002C) /* Get bitrate from a CAN controller */ +#define SIOCSCANBITRATE _SIOC(0x002D) /* Set bitrate of a CAN controller */ +#define SIOCACANEXTFILTER _SIOC(0x002E) /* Add hardware-level exteneded ID filter */ Review Comment: Indeed Linux SocketCAN is SW only using the CAN_RAW_FILTER socketoption (which is already implemented in NuttX). It seems that @JacobCrabill added a direct ioctl to the SocketCAN netdevice to set the hardware filters to avoid unnecessary interrupts and can still nicely co-exist with the SocketCAN software filter to filter further towards different userspace applications. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
