pkarashchenko commented on code in PR #6197: URL: https://github.com/apache/incubator-nuttx/pull/6197#discussion_r880519116
########## libs/libc/stdlib/lib_exit.c: ########## @@ -22,13 +22,38 @@ * Included Files ****************************************************************************/ +#include <nuttx/config.h> + +#include <nuttx/atexit.h> +#include <nuttx/compiler.h> + #include <stdlib.h> #include <unistd.h> +/**************************************************************************** + * Private Data + ****************************************************************************/ + +/**************************************************************************** + * Public Data + ****************************************************************************/ + +extern FAR void *__dso_handle weak_data; +FAR void *__dso_handle = &__dso_handle; Review Comment: I do not fully get it. `extern FAR void *__dso_handle[] weak_data;` states that `__dso_handle` is either provided by a linker or it is evaluated to `NULL` if not. Or the case is that we need to define `__dso_handle` to be non-null? If it is then we can just keep ``` FAR void *__dso_handle weak_data; ``` I need to re-evaluate the meaning of `FAR void *__dso_handle = &__dso_handle;` that I do not fully understand -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
