pkarashchenko commented on code in PR #6422:
URL: https://github.com/apache/incubator-nuttx/pull/6422#discussion_r909297975


##########
arch/arm/src/stm32wb/hardware/stm32wb_dmamux.h:
##########
@@ -0,0 +1,284 @@
+/****************************************************************************
+ * arch/arm/src/stm32wb/hardware/stm32wb_dmamux.h
+ *
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements.  See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.  The
+ * ASF licenses this file to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance with the
+ * License.  You may obtain a copy of the License at
+ *
+ *   http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS, WITHOUT
+ * WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.  See the
+ * License for the specific language governing permissions and limitations
+ * under the License.
+ *
+ ****************************************************************************/
+
+#ifndef __ARCH_ARM_SRC_STM32WB_HARDWARE_STM32WB_DMAMUX_H
+#define __ARCH_ARM_SRC_STM32WB_HARDWARE_STM32WB_DMAMUX_H
+
+/****************************************************************************
+ * Included Files
+ ****************************************************************************/
+
+#include <nuttx/config.h>
+#include "chip.h"
+#include "stm32wb_dma.h"
+
+/****************************************************************************
+ * Pre-processor Definitions
+ ****************************************************************************/
+
+#define DMAMUX1 0
+
+/* Register Offsets *********************************************************/
+
+#define STM32WB_DMAMUX_CXCR_OFFSET(x)  (0x0000 + 0x0004*(x)) /* DMAMUX1 
request line multiplexer channel x configuration register */

Review Comment:
   Optional
   ```suggestion
   #define STM32WB_DMAMUX_CXCR_OFFSET(x)  (0x0000 + 0x0004 * (x)) /* DMAMUX1 
request line multiplexer channel x configuration register */
   ```



##########
arch/arm/src/stm32wb/hardware/stm32wb_dmamux.h:
##########
@@ -0,0 +1,284 @@
+/****************************************************************************
+ * arch/arm/src/stm32wb/hardware/stm32wb_dmamux.h
+ *
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements.  See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.  The
+ * ASF licenses this file to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance with the
+ * License.  You may obtain a copy of the License at
+ *
+ *   http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS, WITHOUT
+ * WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.  See the
+ * License for the specific language governing permissions and limitations
+ * under the License.
+ *
+ ****************************************************************************/
+
+#ifndef __ARCH_ARM_SRC_STM32WB_HARDWARE_STM32WB_DMAMUX_H
+#define __ARCH_ARM_SRC_STM32WB_HARDWARE_STM32WB_DMAMUX_H
+
+/****************************************************************************
+ * Included Files
+ ****************************************************************************/
+
+#include <nuttx/config.h>
+#include "chip.h"
+#include "stm32wb_dma.h"
+
+/****************************************************************************
+ * Pre-processor Definitions
+ ****************************************************************************/
+
+#define DMAMUX1 0
+
+/* Register Offsets *********************************************************/
+
+#define STM32WB_DMAMUX_CXCR_OFFSET(x)  (0x0000 + 0x0004*(x)) /* DMAMUX1 
request line multiplexer channel x configuration register */
+#define STM32WB_DMAMUX_C0CR_OFFSET     STM32WB_DMAMUX_CXCR_OFFSET(0)
+#define STM32WB_DMAMUX_C1CR_OFFSET     STM32WB_DMAMUX_CXCR_OFFSET(1)
+#define STM32WB_DMAMUX_C2CR_OFFSET     STM32WB_DMAMUX_CXCR_OFFSET(2)
+#define STM32WB_DMAMUX_C3CR_OFFSET     STM32WB_DMAMUX_CXCR_OFFSET(3)
+#define STM32WB_DMAMUX_C4CR_OFFSET     STM32WB_DMAMUX_CXCR_OFFSET(4)
+#define STM32WB_DMAMUX_C5CR_OFFSET     STM32WB_DMAMUX_CXCR_OFFSET(5)
+#define STM32WB_DMAMUX_C6CR_OFFSET     STM32WB_DMAMUX_CXCR_OFFSET(6)
+#define STM32WB_DMAMUX_C7CR_OFFSET     STM32WB_DMAMUX_CXCR_OFFSET(7)
+#define STM32WB_DMAMUX_C8CR_OFFSET     STM32WB_DMAMUX_CXCR_OFFSET(8)
+#define STM32WB_DMAMUX_C9CR_OFFSET     STM32WB_DMAMUX_CXCR_OFFSET(9)
+#define STM32WB_DMAMUX_C10CR_OFFSET    STM32WB_DMAMUX_CXCR_OFFSET(10)
+#define STM32WB_DMAMUX_C11CR_OFFSET    STM32WB_DMAMUX_CXCR_OFFSET(11)
+#define STM32WB_DMAMUX_C12CR_OFFSET    STM32WB_DMAMUX_CXCR_OFFSET(12)
+#define STM32WB_DMAMUX_C13CR_OFFSET    STM32WB_DMAMUX_CXCR_OFFSET(13)
+                                              /* 0x034-0x07C: Reserved */
+#define STM32WB_DMAMUX_CSR_OFFSET      0x0080 /* DMAMUX1 request line 
multiplexer interrupt channel status register */
+#define STM32WB_DMAMUX_CFR_OFFSET      0x0084 /* DMAMUX1 request line 
multiplexer interrupt clear flag register */
+                                              /* 0x088-0x0FC: Reserved */
+
+#define STM32WB_DMAMUX_RGXCR_OFFSET(x) (0x0100+0x004*(x)) /* DMAMUX1 request 
generator channel x configuration register */

Review Comment:
   Optional
   ```suggestion
   #define STM32WB_DMAMUX_RGXCR_OFFSET(x) (0x0100 + 0x004 * (x)) /* DMAMUX1 
request generator channel x configuration register */
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to