pkarashchenko commented on code in PR #7924:
URL: https://github.com/apache/nuttx/pull/7924#discussion_r1053082349
##########
drivers/video/fb.c:
##########
@@ -388,6 +388,7 @@ static int fb_ioctl(FAR struct file *filep, int cmd,
unsigned long arg)
DEBUGASSERT(fb->vtable != NULL &&
fb->vtable->getoverlayinfo != NULL);
+ memset(&oinfo, 0, sizeof(oinfo));
Review Comment:
yes, but why memset-ing to 0 is needed? I see that `overlay` field is not
accessed here. Only
```
fb->fbmem = oinfo.fbmem;
fb->fblen = oinfo.fblen;
fb->bpp = oinfo.bpp;
```
the only thing that I can think about is that `getoverlayinfo` will not
update those fields, so I'm asking is that really true?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
