xiaoxiang781216 commented on PR #7975:
URL: https://github.com/apache/nuttx/pull/7975#issuecomment-1364696147
libcxx report the following warning with this patch:
```
[2022-12-25T14:50:41.765Z] libcxx/src/condition_variable.cpp: In member
function 'void
std::__1::condition_variable::__do_timed_wait(std::__1::unique_lock<std::__1::mutex>&,
std::__1::chrono::time_point<std::__1::chrono::system_clock,
std::__1::chrono::duration<long long int, std::__1::ratio<1, 1000000000> > >)':
[2022-12-25T14:50:41.765Z] libcxx/src/condition_variable.cpp:64:19: error:
comparison of integer expressions of different signedness:
'std::__1::chrono::duration<long long int>::rep' {aka 'long long int'} and
'const ts_sec' {aka 'const long long unsigned int'} [-Werror=sign-compare]
[2022-12-25T14:50:41.765Z] 64 | if (s.count() < ts_sec_max)
[2022-12-25T14:50:41.765Z] | ~~~~~~~~~~^~~~~~~~~~~~
```
So, we have to keep the convention used by other OS.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
