TimJTi commented on PR #8155: URL: https://github.com/apache/nuttx/pull/8155#issuecomment-1384433253
> > @TimJTi could you please double check this issue came from you commit [6b4da4a](https://github.com/apache/nuttx/commit/6b4da4ad6e8e7b8bada130c98c785d9f19cfc814) > > Not sure I fully understand what the issue is? Oh, perhaps I do. Perhaps the #endif for the #define checks is too soon and should be after the putreg on line 473. I need to check sam_sfr.h as it is related to that. It all stems from the fact that the SAMA5D4 does not have TRIM capability for UTMI unlike SAMA5D2 and D3 but early datasheets did include this. I will look tomorrow at my PR and do changes as required as I don't think reverting the line: `#if defined(ATSAMA5D2) || defined(ATSAMA5D3)` is necessarily the right answer -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
