SimonFilgis commented on code in PR #8398:
URL: https://github.com/apache/nuttx/pull/8398#discussion_r1103642805
##########
drivers/lcd/Kconfig:
##########
@@ -1104,6 +1104,13 @@ config LCD_RLANDSCAPE
refers one of two orientations where the display is wider than
it is
tall (LCD_LANDSCAPE is the other).
+config LCD_DYN_ORIENTATION
Review Comment:
This define would need to be in the include file to be visible externally.
The CONFIG_ST7789_ORIENTATION needs to be created.
I tried to implement this way you suggested the last 20min and came to the
conclusion that this is a more complicated less understandabel way.
Nuttx inviolable:
Sometimes Code Duplication is OK
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
