[nuttx-apps] branch master updated: readline: Don't echo input except VT100 command

[xiaoxiang]

This is an automated email from the ASF dual-hosted git repository.

xiaoxiang pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/nuttx-apps.git


The following commit(s) were added to refs/heads/master by this push:
     new 8160dd0d5 readline: Don't echo input except VT100 command
8160dd0d5 is described below

commit 8160dd0d5627141da30a49a66f1f794c33a16aaa
Author: Huang Qi <huang...@xiaomi.com>
AuthorDate: Wed Mar 1 23:24:39 2023 +0800

    readline: Don't echo input except VT100 command
    
    Let's echo character by serial driver,
    this will imporve the experience of telnetd,
    which will display input command and newline twice.
    And also enhance the compatiblity with some third party
    linux readline based application (like WAMR repl).
    
    Signed-off-by: Huang Qi <huang...@xiaomi.com>
---
 system/readline/readline_common.c | 10 ----------
 1 file changed, 10 deletions(-)

diff --git a/system/readline/readline_common.c 
b/system/readline/readline_common.c
index 15ed36880..d68faa91b 100644
--- a/system/readline/readline_common.c
+++ b/system/readline/readline_common.c
@@ -708,11 +708,6 @@ ssize_t readline_common(FAR struct rl_common_s *vtbl, FAR 
char *buf,
           buf[nch++] = '\n';
           buf[nch]   = '\0';
 
-#ifdef CONFIG_READLINE_ECHO
-          /* Echo the newline to the console */
-
-          RL_PUTC(vtbl, '\n');
-#endif
           return nch;
         }
 
@@ -724,11 +719,6 @@ ssize_t readline_common(FAR struct rl_common_s *vtbl, FAR 
char *buf,
         {
           buf[nch++] = ch;
 
-#ifdef CONFIG_READLINE_ECHO
-          /* Echo the character to the console */
-
-          RL_PUTC(vtbl, ch);
-#endif
           /* Check if there is room for another character and the line's
            * null terminator.  If not then we have to end the line now.
            */