wengzhe commented on code in PR #8753: URL: https://github.com/apache/nuttx/pull/8753#discussion_r1128898295
########## mm/iob/iob_clone.c: ########## @@ -109,8 +109,8 @@ static int iob_next(FAR struct iob_s *iob, bool throttled, bool block) ****************************************************************************/ int iob_clone_partial(FAR struct iob_s *iob1, unsigned int len, Review Comment: Because with signed offset, we may clone data before iob->io_offset, which contains our L2 data. Using subtraction logic is to make sure the compare result is correct (compare int and unsigned int may be risky since int will be cast to unsigned) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
