pkarashchenko commented on code in PR #8779:
URL: https://github.com/apache/nuttx/pull/8779#discussion_r1133752700
##########
arch/arm64/src/fvp-v8r/fvp_lowputc.S:
##########
@@ -50,24 +50,6 @@
* Public Functions
****************************************************************************/
-/* PL011 UART initialization
- * xb: register which contains the UART base address
- * c: scratch register number
- */
-
-GTEXT(up_earlyserialinit)
-SECTION_FUNC(text, up_earlyserialinit)
Review Comment:
But the things done here are completely different from what is done in
`arm64_earlyserialinit`. This code is branched very early from ASM code and uses
```
GTEXT(arm64_lowputc)
SECTION_FUNC(text, arm64_lowputc)
ldr x15, =CONFIG_UART0_BASE
early_uart_ready x15, w2
early_uart_transmit x15, w0
ret
```
for the low level output. If we remove the `up_earlyserialinit` then non of
the lines like `PRINT(primary_boot, "- Ready to Boot Primary CPU\r\n")` will be
ever printed.
I will take a look into https://github.com/apache/nuttx/pull/8716 , but
seems like we might be breaking an important path of debugging early startup
process
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
